Skip to content

Replace personal name with neutral user wording (NAME-NUTZER) - #1582

Merged
mergify[bot] merged 2 commits into
mainfrom
codex/name-nutzer
Oct 15, 2026
Merged

mergify[bot] merged 2 commits into
mainfrom
codex/name-nutzer

Conversation

@Cuarroc

@Cuarroc Cuarroc commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Der persönliche Vorname ist in den aktuellen Dateien durch „Nutzer“ beziehungsweise „the user“ ersetzt.
Die Plan-Tabellen behalten ihre Struktur, und die Parser sowie die lokalen Prüfungen sind grün.
Die unabhängige Prüfung steht noch aus; dieser PR bleibt deshalb ein Entwurf.

Report

Plan-ID: NAME-NUTZER

  • Operator: UMSETZEN; owner: assigned worker srv-name-nutzer.
  • Authority: the user's option A decision of 2026-10-15, supplied in the dispatch.
  • Base: main / origin/main at job start, 3ad56a8a2c231d5f4d56730a00b26101c6b29d95; fetched again before push and unchanged.
  • Candidate: e36245284df9ec990f4d60b6505112ed768c47ff, branch codex/name-nutzer.
  • Scope: 96 occurrences on 91 lines in 11 tracked files; 91 additions + 91 deletions = 182 diff lines, below the 300-line limit. No seam changes.

Changes and parser check

File Replaced lines
docs/PLAN.md 59
docs/plan/v2.0/plan.md 12
docs/decisions.md 7
docs/plan/v2.0/retire.md 3
docs/plan/v2.0/terminal.md 2
docs/development/prompting.md 2
scripts/lib/hq-parse.test.mjs 2
scripts/review/accept-check.mjs 1
scripts/dev/brief-lint.mjs 1
.agents/skills/projecta-workflow/SKILL.md 1
.claude/skills/projecta-workflow/SKILL.md 1

German prose uses the appropriate articles and possessives; English prose uses “the user”. Owner cells use “Nutzer”. The two decision messages use “Nutzer-Entscheidung”; both HQ fixture rows use the neutral owner.

Inspected owner handling in scripts/lib/plan-model.mjs, scripts/lib/hq-parse.mjs, scripts/dev/brief-lint.mjs, scripts/review/accept-check.mjs, and searched the scripts tree for owner comparisons and name references. Both PLAN parsers pass owner text through; no parser logic change was necessary. A Node assertion comparison of base/current PLAN projections confirmed identical IDs, statuses and dependencies and equivalent neutralized owners in both parsers. A Python comparison confirmed unchanged line counts and Markdown table separators. No test assertions were weakened or added; the commit uses the authorized wording-only test exemption.

Evidence (2026-10-15, Linux)

Command Exit Result
node --test scripts/lib/hq-parse.test.mjs scripts/lib/plan-model.test.mjs scripts/lib/dev-brief-lint.test.mjs scripts/lib/review-accept-check.test.mjs 0 79 passed
node --input-type=module (base/current parser comparison described above) 0 Equivalent package projections
python3 (base/current line and table-shape comparison) 0 96 replacements in 11 files; shape preserved
git grep -I -c <private-search-term> 1 No output: no remaining occurrences; the literal private term is deliberately omitted from this public report
git diff --check 0 No whitespace errors
bash scripts/ci/secret-scan.sh before commit 0 No leaks
git commit with normal hooks 0 Full precommit lane green
bash scripts/ci/red-first.sh 0 Wording-only exemption accepted
bash scripts/ci/gates.sh lane prepush 0 Full lane, 288 s, candidate above
git push -u origin codex/name-nutzer 0 Normal hook repeated full prepush successfully, 161 s
git ls-remote origin codex/name-nutzer 0 Remote SHA equals the candidate

Both prepush runs passed 1,458 frontend tests and 2,273 Rust tests; Rust reported 7 existing skips. HQ reported 888 passed / 2 skipped; Denkraum reported 388 passed / 1 skipped plus 33 passed browser tests. Start checks exited 0 before the runs. No dependency or architecture changes.

NICHT ABGEDECKT

  • Linux does not compile or run #[cfg(windows)] tests (including ConPTY, DPAPI, Windows PTY and npm-shim paths), or Windows-only Clippy branches. The Windows lane runs in the merge queue.
  • Existing platform-dependent and ignored tests retain their skips. The full linux lane's additional browser smoke, frontend build and workflow gates were not run separately.
  • External updater, router and mirror services were not tested. No visual or desktop-runtime acceptance is claimed.
  • Git history remains unchanged. Generated HQ snapshots and .pa/ACTIVITY.md were not edited.
  • The local lage-jetzt mirror was unavailable; live Git and PR state was checked instead. Provider quota and the harness's actual model were not independently observed by the start check.

Review and handover

Review: ausstehend (Stufe B)

The orchestrator arranges the independent review; this dispatch requests one reviewer from a family other than the author's. No review verdict, acceptance or merge is claimed. Native worker goal was created and verified through the harness; its bounded endpoint is this tested, pushed draft handover. Parent integration remains with the orchestrator.

Overlap: #1580 (codex/roadmap-1a) was still OPEN when checked after push. Its scripts/lib/roadmap-data.mjs owner mapping must recognize “Nutzer” and map it to “du”. Whichever PR merges second must reconcile that mapping and repeat the tracked-file name check. That other branch was not edited.

Next owner: orchestrator, for review, overlap reconciliation and integration through the normal queue.

Review disposition (Root, head e362452)

Tier B, author family OpenAI (Codex). Reviewer: Gemini 3.8 Flash (Google, OpenRouter second-review lane), verdict APPROVE on e362452.

ID Source Severity Finding Disposition
G1 Gemini medium accept-check.mjs:42, brief-lint.mjs:119: changed output strings may break consumers that match the text Rejected. The machine contract is the exit code (0/2/3). The only test asserts AUTO-OK, which is unchanged. git grep on the branch and a grep over the pa-orch scripts (19:5x) found no consumer of the old text.
G2 Gemini low docs/decisions.md:2005 wording Follow-up, no code.
G3 Gemini low same two output strings, wording Follow-up, no code.
R1582-A1 Claude medium docs/plan/v2.0/plan.md:881 links to the old decision heading slug Accepted + commit b8bfa32be7aef6985d1de8c7d6c4fc02d390e558; updated fragment to match the renamed heading.

Root check: git grep -c -I Elias origin/codex/name-nutzer prints nothing.

Delta review (Root, Claude Opus 5.5 / Anthropic; author of the delta: Codex / OpenAI)

  • Delta reviewed: e362452..b8bfa32, one line in docs/plan/v2.0/plan.md.
  • The new fragment matches GitHub's slug for docs/decisions.md:2109 ("2026-10-15 - Design-system decisions D1–D7 (Root by delegation, the user may overrule)" → #2026-10-15---design-system-decisions-d1d7-root-by-delegation-the-user-may-overrule).
  • git grep -c -I -i elias origin/codex/name-nutzer prints nothing (exit 1).
  • Trailer: No-Test with a real reason.
  • Verdict: APPROVE. R1582-A1 (Claude, medium) is accepted and fixed in b8bfa32.

No-Test: wording only; parser logic and test assertions are unchanged.
@Cuarroc
Cuarroc marked this pull request as ready for review October 15, 2026 17:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T17:57:13.972012Z e362452 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e36245284d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/decisions.md
may be lost. This contract itself starts, migrates, exposes or retires nothing.

## 2026-10-15 - Design-system decisions D1–D7 (Root by delegation, Elias may overrule)
## 2026-10-15 - Design-system decisions D1–D7 (Root by delegation, the user may overrule)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Aktualisiere den eingehenden Link auf den umbenannten Anker

Durch die Umbenennung dieser Überschrift ändert sich ihr Markdown-Anker zu #2026-10-15---design-system-decisions-d1d7-root-by-delegation-the-user-may-overrule, aber docs/plan/v2.0/plan.md:881 verweist weiterhin auf den alten ...-elias-may-overrule-Anker. Dadurch führt der D1–D7-Link nicht mehr zum Entscheidungsabschnitt und der zu entfernende persönliche Name bleibt zudem in einer aktuellen Datei erhalten; bitte den eingehenden Link zusammen mit der Überschrift aktualisieren.

Useful? React with 👍 / 👎.

No-Test: one anchor fragment in a docs link (doc-links.mjs does not check anchors)
@Cuarroc Cuarroc added the review-ok Pipeline: review disposition complete, no open high finding label Oct 15, 2026
@Cuarroc

Cuarroc commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Root: review-ok bound to head b8bfa32. Tier B, the author is Codex (OpenAI). Claude Sonnet 5.5 (Anthropic) APPROVE at b8bfa32 after R1582-A1 was fixed; Root (Anthropic) delta APPROVE; Gemini (Google) APPROVE. All checks green incl. CodeQL and GitGuardian at 2026-10-15T18:16:26Z.

@Cuarroc

Cuarroc commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Root auto-queue: head b8bfa32 unchanged since review-ok, all checks green. @Mergifyio queue

@mergify mergify Bot added the queued label Oct 15, 2026
@mergify
mergify Bot merged commit 0f2cd8d into main Oct 15, 2026
18 checks passed
@mergify

mergify Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 16 minutes 43 seconds in the queue, including 16 minutes 13 seconds running CI.

Required conditions to merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections

@mergify
mergify Bot deleted the codex/name-nutzer branch October 15, 2026 18:33
@mergify mergify Bot removed the queued label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-ok Pipeline: review disposition complete, no open high finding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant