Repository navigation
Replace personal name with neutral user wording (NAME-NUTZER) - #1582
Conversation
No-Test: wording only; parser logic and test assertions are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e36245284d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| may be lost. This contract itself starts, migrates, exposes or retires nothing. | ||
|
|
||
| ## 2026-10-15 - Design-system decisions D1–D7 (Root by delegation, Elias may overrule) | ||
| ## 2026-10-15 - Design-system decisions D1–D7 (Root by delegation, the user may overrule) |
There was a problem hiding this comment.
Aktualisiere den eingehenden Link auf den umbenannten Anker
Durch die Umbenennung dieser Überschrift ändert sich ihr Markdown-Anker zu #2026-10-15---design-system-decisions-d1d7-root-by-delegation-the-user-may-overrule, aber docs/plan/v2.0/plan.md:881 verweist weiterhin auf den alten ...-elias-may-overrule-Anker. Dadurch führt der D1–D7-Link nicht mehr zum Entscheidungsabschnitt und der zu entfernende persönliche Name bleibt zudem in einer aktuellen Datei erhalten; bitte den eingehenden Link zusammen mit der Überschrift aktualisieren.
Useful? React with 👍 / 👎.
No-Test: one anchor fragment in a docs link (doc-links.mjs does not check anchors)
|
Root auto-queue: head b8bfa32 unchanged since review-ok, all checks green. @Mergifyio queue |
Merge Queue Status
This pull request spent 16 minutes 43 seconds in the queue, including 16 minutes 13 seconds running CI. Required conditions to merge
|
Der persönliche Vorname ist in den aktuellen Dateien durch „Nutzer“ beziehungsweise „the user“ ersetzt.
Die Plan-Tabellen behalten ihre Struktur, und die Parser sowie die lokalen Prüfungen sind grün.
Die unabhängige Prüfung steht noch aus; dieser PR bleibt deshalb ein Entwurf.
Report
Plan-ID: NAME-NUTZER
srv-name-nutzer.main/origin/mainat job start,3ad56a8a2c231d5f4d56730a00b26101c6b29d95; fetched again before push and unchanged.e36245284df9ec990f4d60b6505112ed768c47ff, branchcodex/name-nutzer.Changes and parser check
docs/PLAN.mddocs/plan/v2.0/plan.mddocs/decisions.mddocs/plan/v2.0/retire.mddocs/plan/v2.0/terminal.mddocs/development/prompting.mdscripts/lib/hq-parse.test.mjsscripts/review/accept-check.mjsscripts/dev/brief-lint.mjs.agents/skills/projecta-workflow/SKILL.md.claude/skills/projecta-workflow/SKILL.mdGerman prose uses the appropriate articles and possessives; English prose uses “the user”. Owner cells use “Nutzer”. The two decision messages use “Nutzer-Entscheidung”; both HQ fixture rows use the neutral owner.
Inspected owner handling in
scripts/lib/plan-model.mjs,scripts/lib/hq-parse.mjs,scripts/dev/brief-lint.mjs,scripts/review/accept-check.mjs, and searched the scripts tree for owner comparisons and name references. Both PLAN parsers pass owner text through; no parser logic change was necessary. A Node assertion comparison of base/current PLAN projections confirmed identical IDs, statuses and dependencies and equivalent neutralized owners in both parsers. A Python comparison confirmed unchanged line counts and Markdown table separators. No test assertions were weakened or added; the commit uses the authorized wording-only test exemption.Evidence (2026-10-15, Linux)
node --test scripts/lib/hq-parse.test.mjs scripts/lib/plan-model.test.mjs scripts/lib/dev-brief-lint.test.mjs scripts/lib/review-accept-check.test.mjsnode --input-type=module(base/current parser comparison described above)python3(base/current line and table-shape comparison)git grep -I -c <private-search-term>git diff --checkbash scripts/ci/secret-scan.shbefore commitgit commitwith normal hooksbash scripts/ci/red-first.shbash scripts/ci/gates.sh lane prepushgit push -u origin codex/name-nutzergit ls-remote origin codex/name-nutzerBoth prepush runs passed 1,458 frontend tests and 2,273 Rust tests; Rust reported 7 existing skips. HQ reported 888 passed / 2 skipped; Denkraum reported 388 passed / 1 skipped plus 33 passed browser tests. Start checks exited 0 before the runs. No dependency or architecture changes.
NICHT ABGEDECKT
#[cfg(windows)]tests (including ConPTY, DPAPI, Windows PTY and npm-shim paths), or Windows-only Clippy branches. The Windows lane runs in the merge queue.linuxlane's additional browser smoke, frontend build and workflow gates were not run separately..pa/ACTIVITY.mdwere not edited.lage-jetztmirror was unavailable; live Git and PR state was checked instead. Provider quota and the harness's actual model were not independently observed by the start check.Review and handover
Review: ausstehend (Stufe B)
The orchestrator arranges the independent review; this dispatch requests one reviewer from a family other than the author's. No review verdict, acceptance or merge is claimed. Native worker goal was created and verified through the harness; its bounded endpoint is this tested, pushed draft handover. Parent integration remains with the orchestrator.
Overlap: #1580 (
codex/roadmap-1a) was still OPEN when checked after push. Itsscripts/lib/roadmap-data.mjsowner mapping must recognize “Nutzer” and map it to “du”. Whichever PR merges second must reconcile that mapping and repeat the tracked-file name check. That other branch was not edited.Next owner: orchestrator, for review, overlap reconciliation and integration through the normal queue.
Review disposition (Root, head e362452)
Tier B, author family OpenAI (Codex). Reviewer: Gemini 3.8 Flash (Google, OpenRouter second-review lane), verdict APPROVE on e362452.
accept-check.mjs:42,brief-lint.mjs:119: changed output strings may break consumers that match the textAUTO-OK, which is unchanged.git grepon the branch and a grep over the pa-orch scripts (19:5x) found no consumer of the old text.docs/decisions.md:2005wordingdocs/plan/v2.0/plan.md:881links to the old decision heading slugb8bfa32be7aef6985d1de8c7d6c4fc02d390e558; updated fragment to match the renamed heading.Root check:
git grep -c -I Elias origin/codex/name-nutzerprints nothing.Delta review (Root, Claude Opus 5.5 / Anthropic; author of the delta: Codex / OpenAI)
docs/plan/v2.0/plan.md.docs/decisions.md:2109("2026-10-15 - Design-system decisions D1–D7 (Root by delegation, the user may overrule)" →#2026-10-15---design-system-decisions-d1d7-root-by-delegation-the-user-may-overrule).git grep -c -I -i elias origin/codex/name-nutzerprints nothing (exit 1).No-Testwith a real reason.